lkml.org 
[lkml]   [2009]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: nfs mount fail

* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> Hi Ingo,
>
> On Mon, 2009-10-19 at 08:54 +0200, Ingo Molnar wrote:
> > * Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> >
> > > > yes. something miss merged again...
> > > >
> > > > need change some lines.
> > >
> > > This doesn't match mainline either. To do so, the above kfree() has to
> > > be at the end of the "Opt_xprt_rdma:" case...
> >
> > it's from a test patch in tip:out-of-tree:
> >
> > d40bc6b: <not-for-merge> nfs: fix nfs_parse_mount_options() double kfree()
> >
> > (attached below)
> >
> > that fix is wrong apparently - is there a correct fix upstream perhaps?
>
> AFAICT, yes. See commit d508afb437daee7cf07da085b635c44a4ebf9b38 ("NFS:
> Fix a double free in nfs_parse_mount_options()") from Trond.

sigh. That was written 3 days after your and Yinghai's patch was sent -
there's no Reported-by credit, there was no Cc: back to the original
thread - plus there was a memory leak was left in there as well. Trond?

Ingo


\
 
 \ /
  Last update: 2009-10-19 09:11    [W:0.083 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site