lkml.org 
[lkml]   [2009]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/6] ACPI: dock: convert sysfs attributes to an attribute_group
    Hi Alex,

    On Fri, Oct 16, 2009 at 03:14:59PM -0600, Alex Chiang wrote:
    > As suggested by Dmitry Torokhov, convert the individual sysfs
    > attributes into an attribute group.
    >
    > This change eliminates quite a bit of copy/paste code in the
    > error handling paths.
    >

    Looks much better, one more suggestion though:

    > +err_unregister:
    > + printk(KERN_ERR "%s encountered error %d\n", __func__, ret);

    If you want to print error this it should probably go down, right before
    "return ret".

    > + sysfs_remove_group(&dock_device->dev.kobj, &dock_attribute_group);

    It begs another label right here. There are cases when yo0u already
    registered the platform device but haven't added the sysfs group, right?

    > platform_device_unregister(dock_device);
    > +out:
    > kfree(dock_station);
    > dock_station = NULL;
    > return ret;
    > @@ -1076,11 +1046,7 @@ static int dock_remove(struct dock_station *dock_station)
    > kfree(dd);
    >
    > /* cleanup sysfs */
    > - device_remove_file(&dock_device->dev, &dev_attr_type);
    > - device_remove_file(&dock_device->dev, &dev_attr_docked);
    > - device_remove_file(&dock_device->dev, &dev_attr_undock);
    > - device_remove_file(&dock_device->dev, &dev_attr_uid);
    > - device_remove_file(&dock_device->dev, &dev_attr_flags);
    > + sysfs_remove_group(&dock_device->dev.kobj, &dock_attribute_group);
    > platform_device_unregister(dock_device);
    >
    > /* free dock station memory */
    >

    --
    Dmitry


    \
     
     \ /
      Last update: 2009-10-18 09:19    [W:0.024 / U:0.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site