Messages in this thread | | | Date | Sat, 17 Oct 2009 19:01:24 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] power: pcf50633: introduces battery charging current control |
| |
Hi!
> From: Balaji Rao <balajirrao@openmoko.org>
Could we get some changelog here? Like 'it adds new file to sysfs interface, ...'
> +static ssize_t > +show_chglim(struct device *dev, struct device_attribute *attr, char *buf)
Could we get meaningful function names?
> @@ -31,6 +31,8 @@ struct pcf50633_platform_data { > > int charging_restart_interval; > > + int chg_ref_current_ma; > +
...and variable names? This is also inconsistent with name above.
Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |