lkml.org 
[lkml]   [2009]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power: pcf50633: introduces battery charging current control
Hi!

> From: Balaji Rao <balajirrao@openmoko.org>

Could we get some changelog here? Like 'it adds new file to sysfs
interface, ...'



> +static ssize_t
> +show_chglim(struct device *dev, struct device_attribute *attr, char *buf)

Could we get meaningful function names?

> @@ -31,6 +31,8 @@ struct pcf50633_platform_data {
>
> int charging_restart_interval;
>
> + int chg_ref_current_ma;
> +

...and variable names? This is also inconsistent with name above.

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-10-18 20:27    [from the cache]
©2003-2011 Jasper Spaans