lkml.org 
[lkml]   [2009]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] clockevents.c: fix symbol was not declared noise
    From
    On Sat, Oct 17, 2009 at 6:19 AM, H Hartley Sweeten
    <hartleys@visionengravers.com> wrote:
    > Include "tick-internal.h" in order to pick up the extern function
    > prototype for clockevents_shutdown().  This quiets the following
    > spares build noise:
    >
    >  warning: symbol 'clockevents_shutdown' was not declared. Should it be static?
    >
    > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
    >

    Looks good.
    Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>

    Cc'ed some experts.

    > ---
    >
    > diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
    > index 620b58a..c30ba1f 100644
    > --- a/kernel/time/clockevents.c
    > +++ b/kernel/time/clockevents.c
    > @@ -20,6 +20,8 @@
    >  #include <linux/sysdev.h>
    >  #include <linux/tick.h>
    >
    > +#include "tick-internal.h"
    > +
    >  /* The registered clock event devices */
    >  static LIST_HEAD(clockevent_devices);
    >  static LIST_HEAD(clockevents_released);
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at  http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at  http://www.tux.org/lkml/
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-10-18 08:35    [W:0.022 / U:58.696 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site