Messages in this thread | | | Date | Fri, 16 Oct 2009 10:09:35 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v9 4/5] core: Add kernel message dumper to call on oopses and panics |
| |
* Simon Kagstrom <simon.kagstrom@netinsight.net> wrote:
/** * kmsg_dump_register - register a kernel log dumper. * @dump: pointer to the kmsg_dumper structure * * Adds a kernel log dumper to the system. The dump callback in the * structure will be called when the kernel oopses or panics and must be * set. Returns zero on success and -EINVAL or -EBUSY otherwise. */
Small detail - please use the KernelDoc style used in existing printk.c facilities, i.e. use a single space instead of a tab:
/** * kmsg_dump_register - register a kernel log dumper. * @dump: pointer to the kmsg_dumper structure * * Adds a kernel log dumper to the system. The dump callback in the * structure will be called when the kernel oopses or panics and must be * set. Returns zero on success and -EINVAL or -EBUSY otherwise. */
(in the other functions as well)
Ingo
| |