Messages in this thread | | | Subject | Re: [PATCH 6/7] checkpatch: fix false EXPORT_SYMBOL warning | From | Daniel Walker <> | Date | Fri, 16 Oct 2009 11:58:21 -0700 |
| |
On Fri, 2009-10-16 at 19:39 +0100, Andy Whitcroft wrote:
> - WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr); > +#print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n"; > + $suppress_export{$realline_next} = 2; > + } else { > + $suppress_export{$realline_next} = 1; > } > } > + if (!defined $suppress_export{$linenr} && > + $prevline =~ /^.\s*$/ && > + ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ || > + $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
ERROR: code indent should use tabs where possible #148: FILE: scripts/checkpatch.pl:1734: + ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||$
This one line is spaced over instead of tabbed.. I guess checkpatch can even check itself, which is nice .. I'm not sure this matters since this it's perl tho..
Do you apply any kind of coding style to checkpatch itself ?
Daniel
| |