lkml.org 
[lkml]   [2009]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mm/nommu.c: Fix improperly call of security API in mmap
Date
Eric Paris <eparis@redhat.com> wrote:

> That would still call cap_file_mmap() and wouldn't solve your problem.

Hmmm... I guess I don't see the problem occur because I always run the
programs as root.

I would guess that cap_file_mmap() and selinux_file_mmap() are, perhaps, too
strict. The hint shouldn't be rejected unless MAP_FIXED is also set, surely,
but should rather be revised upwards.

Certainly, addr==NULL and !MAP_FIXED is a reasonable case to permit, even in
tightly secured MMU and SELinux mode... After all, the manual page says:

If addr is NULL, then the kernel chooses the address at which to create
the mapping; this is the most portable method of creating a new map-
ping.

David


\
 
 \ /
  Last update: 2009-10-16 17:55    [W:0.075 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site