Messages in this thread | | | Date | Fri, 16 Oct 2009 14:25:54 +0300 | From | Aaro Koskinen <> | Subject | Re: [PATCH v10 4/5] core: Add kernel message dumper to call on oopses and panics |
| |
Hello,
Simon Kagstrom wrote: > +#ifndef _LINUX_KMSG_DUMP_H > +#define _LINUX_KMSG_DUMP_H > + > +#include <linux/list.h> > + > +enum kmsg_dump_reason { > + KMSG_DUMP_OOPS, > + KMSG_DUMP_PANIC, > +}; > + > +/** > + * struct kmsg_dumper - kernel crash message dumper structure > + * @dump: The callback which gets called on crashes. The buffer is passed > + * as two sections, where s1 (length l1) contains the older > + * messages and s2 (length l2) contains the newer. > + * @list: Entry in the dumper list (private) > + * @registered: Flag that specifies if this is already registered > + */ > +struct kmsg_dumper { > + void (*dump)(struct kmsg_dumper *dumper, enum kmsg_dump_reason reason, > + const char *s1, unsigned long l1, > + const char *s2, unsigned long l2); > + struct list_head list; > + int registered; > +}; > + > +void kmsg_dump(enum kmsg_dump_reason reason); > + > +int kmsg_dump_register(struct kmsg_dumper *dumper); > + > +int kmsg_dump_unregister(struct kmsg_dumper *dumper); > + > +#endif /* _LINUX_DUMP_DEVICE_H */
If you still make a new version of the patch, please correct the "_LINUX_DUMP_DEVICE_H" comment.
A.
| |