Messages in this thread | | | From | vimal singh <> | Date | Thu, 15 Oct 2009 10:41:39 +0530 | Subject | Re: [PATCH v6 5/5]: mtdoops: refactor as a kmsg_dumper |
| |
On Wed, Oct 14, 2009 at 8:42 PM, Simon Kagstrom <simon.kagstrom@netinsight.net> wrote: > On Wed, 14 Oct 2009 15:41:24 +0200 > Simon Kagstrom <simon.kagstrom@netinsight.net> wrote: > >> -static void __exit mtdoops_console_exit(void) >> +static void __exit mtdoops_exit(void) >> { >> struct mtdoops_context *cxt = &oops_cxt; >> >> unregister_mtd_user(&mtdoops_notifier); >> - unregister_console(&mtdoops_console); >> kfree(cxt->name); > > The kfree should go as well since cxt->name is no longer allocated. I'll > await further comments and send a new patch tomorrow. > Help description for 'MTD_OOPS' in Kconfig needs update after this patch. Are you planning to add a patch for same in this series?
-vimal
> // Simon > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |