Messages in this thread | | | Subject | Re: [PATCH] scripts/get_maintainer.pl: add role output option | From | Joe Perches <> | Date | Wed, 14 Oct 2009 21:42:27 -0700 |
| |
On Thu, 2009-10-15 at 04:51 +0100, Ben Hutchings wrote: > Add the output option '--roles' to get_maintainer.pl. This causes it > to show the role of each email address, i.e. why it was selected.
Hi Ben.
Interesting idea.
This patch applies with offsets against the latest version that Andrew Morton has in his tree.
Here are the patches I posted a few days ago: http://lkml.org/lkml/2009/10/10/11
Are the email addresses generated going to be acceptable to all mailers or is --roles just used for visual inspection?
Have you tested it with git-send-email --cc-cmd "scripts/get_maintainer.pl --roles" ?
Trivial comment:
> + push_email_address($line, 'signed-off'); [] > + push_email_address($line, 'blamed');
The "signed-off" role though isn't necessarily an actual "Signed-off-by:". It could be an "Acked-by:", or "tested-by:", or "reviewed-By:".
And the "blamed" keyword may be unnecessarily negative.
Maybe it could be "git-signer" and "modified-author"
cheers, Joe
| |