Messages in this thread Patch in this message | | | Date | Fri, 16 Oct 2009 04:28:37 +0400 | From | Alexey Dobriyan <> | Subject | [PATCH] sysctl: fix false positives when PROC_SYSCTL=n |
| |
Having ->procname but not ->proc_handler is valid when PROC_SYSCTL=n, people use such combination to reduce ifdefs with non-standard handlers.
http://bugzilla.kernel.org/show_bug.cgi?id=14408
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> ---
kernel/sysctl_check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/sysctl_check.c +++ b/kernel/sysctl_check.c @@ -1521,7 +1521,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table) if (!table->ctl_name && table->strategy) set_fail(&fail, table, "Strategy without ctl_name"); #endif -#ifdef CONFIG_PROC_FS +#ifdef CONFIG_PROC_SYSCTL if (table->procname && !table->proc_handler) set_fail(&fail, table, "No proc_handler"); #endif
| |