lkml.org 
[lkml]   [2009]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 2/2] x86_64: align RODATA kernel section to 2MB with CONFIG_DEBUG_RODATA
From
Date
On Wed, 2009-10-14 at 20:24 -0700, Sam Ravnborg wrote:
> > +#else
> > +
> > +#define X64_ALIGN_DEBUG_RODATA_BEGIN
> > +#define X64_ALIGN_DEBUG_RODATA_END
> > +
> > +#endif
>
> A coment describing the purpose of
> this would be nice.

I will update this in the next version of the patch.

> > @@ -726,9 +726,13 @@ void set_kernel_text_ro(void)
> >
> > void mark_rodata_ro(void)
> > {
> > - unsigned long start = PFN_ALIGN(_text), end = PFN_ALIGN(__end_rodata);
> > + unsigned long start = PFN_ALIGN(_text);
> > unsigned long rodata_start =
> > ((unsigned long)__start_rodata + PAGE_SIZE - 1) & PAGE_MASK;
> > + unsigned long end = (unsigned long) &__end_rodata_hpage_align;
> Here the symbol seems to be referenced unconditionally.

This function is defined only for CONFIG_DEBUG_RODATA.

thanks,
suresh



\
 
 \ /
  Last update: 2009-10-15 22:29    [W:0.077 / U:2.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site