Messages in this thread | | | Date | Thu, 15 Oct 2009 08:18:07 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: linker script syntax nits |
| |
* Roland McGrath <roland@redhat.com> wrote:
> The following changes since commit 80f506918fdaaca6b574ba931536a58ce015c7be: > Linus Torvalds (1): > Merge branch 'for-linus' of git://git.kernel.dk/linux-2.6-block > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland.git topic/x86-lds-nits > > Roland McGrath (1): > x86: linker script syntax nits > > arch/x86/kernel/acpi/realmode/wakeup.lds.S | 4 ++-- > arch/x86/kernel/vmlinux.lds.S | 17 ++++++++--------- > 2 files changed, 10 insertions(+), 11 deletions(-) > --- > [PATCH] x86: linker script syntax nits > > The linker scripts grew some use of weirdly wrong linker script syntax. > It happens to work, but it's not what the syntax is documented to be. > Clean it up to use the official syntax.
I've queued up a revert based on Peter's and Sam's objections.
I'd also like to point out a few commit log quality nits. A standard x86 commit should have the following title:
x86: Clean up linker script syntax nits
not:
x86: linker script syntax nits
Note that we always try to add a verb to that sentence, so that it's more natural-language alike. (also note the capitalization (we capitalize the sentence after the 'x86:' prefix))
(Plus i always try to line-wrap the commit log to 65 columns, to make it easy to quote to several levels and still be within the various viewer column widths that people use - and to allow for the +4 columns used up by git log's indentation.)
Thanks,
Ingo
| |