lkml.org 
[lkml]   [2009]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] rtc: Do not use container_of macro as an argument for to_platform_device
    Date
    The to_platform_device macro itself uses container_of macro.
    Nested use of container_of macro causes following sparse warnings:

    rtc-ds1553.c:259:3: warning: symbol '__mptr' shadows an earlier one
    rtc-ds1553.c:259:3: originally declared here

    Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
    ---
    drivers/rtc/rtc-ds1553.c | 8 ++++----
    drivers/rtc/rtc-ds1742.c | 8 ++++----
    drivers/rtc/rtc-stk17ta8.c | 8 ++++----
    3 files changed, 12 insertions(+), 12 deletions(-)

    diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c
    index dadd0f5..ed1ef7c 100644
    --- a/drivers/rtc/rtc-ds1553.c
    +++ b/drivers/rtc/rtc-ds1553.c
    @@ -255,8 +255,8 @@ static ssize_t ds1553_nvram_read(struct kobject *kobj,
    struct bin_attribute *bin_attr,
    char *buf, loff_t pos, size_t size)
    {
    - struct platform_device *pdev =
    - to_platform_device(container_of(kobj, struct device, kobj));
    + struct device *dev = container_of(kobj, struct device, kobj);
    + struct platform_device *pdev = to_platform_device(dev);
    struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
    void __iomem *ioaddr = pdata->ioaddr;
    ssize_t count;
    @@ -270,8 +270,8 @@ static ssize_t ds1553_nvram_write(struct kobject *kobj,
    struct bin_attribute *bin_attr,
    char *buf, loff_t pos, size_t size)
    {
    - struct platform_device *pdev =
    - to_platform_device(container_of(kobj, struct device, kobj));
    + struct device *dev = container_of(kobj, struct device, kobj);
    + struct platform_device *pdev = to_platform_device(dev);
    struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
    void __iomem *ioaddr = pdata->ioaddr;
    ssize_t count;
    diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c
    index 19d2f33..a127336 100644
    --- a/drivers/rtc/rtc-ds1742.c
    +++ b/drivers/rtc/rtc-ds1742.c
    @@ -131,8 +131,8 @@ static ssize_t ds1742_nvram_read(struct kobject *kobj,
    struct bin_attribute *bin_attr,
    char *buf, loff_t pos, size_t size)
    {
    - struct platform_device *pdev =
    - to_platform_device(container_of(kobj, struct device, kobj));
    + struct device *dev = container_of(kobj, struct device, kobj);
    + struct platform_device *pdev = to_platform_device(dev);
    struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
    void __iomem *ioaddr = pdata->ioaddr_nvram;
    ssize_t count;
    @@ -146,8 +146,8 @@ static ssize_t ds1742_nvram_write(struct kobject *kobj,
    struct bin_attribute *bin_attr,
    char *buf, loff_t pos, size_t size)
    {
    - struct platform_device *pdev =
    - to_platform_device(container_of(kobj, struct device, kobj));
    + struct device *dev = container_of(kobj, struct device, kobj);
    + struct platform_device *pdev = to_platform_device(dev);
    struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
    void __iomem *ioaddr = pdata->ioaddr_nvram;
    ssize_t count;
    diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c
    index df3b6c5..eb486ca 100644
    --- a/drivers/rtc/rtc-stk17ta8.c
    +++ b/drivers/rtc/rtc-stk17ta8.c
    @@ -247,8 +247,8 @@ static ssize_t stk17ta8_nvram_read(struct kobject *kobj,
    struct bin_attribute *attr, char *buf,
    loff_t pos, size_t size)
    {
    - struct platform_device *pdev =
    - to_platform_device(container_of(kobj, struct device, kobj));
    + struct device *dev = container_of(kobj, struct device, kobj);
    + struct platform_device *pdev = to_platform_device(dev);
    struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
    void __iomem *ioaddr = pdata->ioaddr;
    ssize_t count;
    @@ -262,8 +262,8 @@ static ssize_t stk17ta8_nvram_write(struct kobject *kobj,
    struct bin_attribute *attr, char *buf,
    loff_t pos, size_t size)
    {
    - struct platform_device *pdev =
    - to_platform_device(container_of(kobj, struct device, kobj));
    + struct device *dev = container_of(kobj, struct device, kobj);
    + struct platform_device *pdev = to_platform_device(dev);
    struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
    void __iomem *ioaddr = pdata->ioaddr;
    ssize_t count;
    --
    1.5.6.5


    \
     
     \ /
      Last update: 2009-10-14 16:23    [W:0.022 / U:3.828 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site