lkml.org 
[lkml]   [2009]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] mfd: twl4030-power: do not allow negative or zero length script
    Date
    The script length cannot be negative. If the length is zero, return
    an error.

    The patch eliminates the following compiler warning:

    drivers/mfd/twl4030-power.c: In function 'twl4030_power_init':
    drivers/mfd/twl4030-power.c:151: warning: 'err' may be used uninitialized in this function
    drivers/mfd/twl4030-power.c:151: note: 'err' was declared here

    Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
    ---
    drivers/mfd/twl4030-power.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
    index d423e0c..eae6cda 100644
    --- a/drivers/mfd/twl4030-power.c
    +++ b/drivers/mfd/twl4030-power.c
    @@ -146,9 +146,9 @@ out:
    }

    static int __init twl4030_write_script(u8 address, struct twl4030_ins *script,
    - int len)
    + unsigned len)
    {
    - int err;
    + int err = EINVAL;

    for (; len; len--, address++, script++) {
    if (len == 1) {
    --
    1.6.0.4


    \
     
     \ /
      Last update: 2009-10-14 14:27    [W:0.038 / U:64.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site