Messages in this thread | | | Date | Tue, 13 Oct 2009 16:54:03 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] ixj: Fix test in ixj_selfprobe() |
| |
On Tue, 06 Oct 2009 17:47:16 +0200 Roel Kluin <roel.kluin@gmail.com> wrote:
> Not makes it a bool before the comparison. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > Was below intended? > > diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c > index 40de151..da3c9a0 100644 > --- a/drivers/telephony/ixj.c > +++ b/drivers/telephony/ixj.c > @@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j) > } else { > switch (j->cardtype) { > case QTI_PHONEJACK: > - if (!j->dsp.low != 0x20) { > + if (j->dsp.low != 0x20) { > j->dsp.high = 0x80; > j->dsp.low = 0x20; > ixj_WriteDSPCommand(0x3800, j);
gee, I can't tell. Presumably it'd be safer to just delete the test - it's a no-op at present and that code is well-tested, lol.
| |