lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ixj: Fix test in ixj_selfprobe()
On Tue, 06 Oct 2009 17:47:16 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:

> Not makes it a bool before the comparison.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Was below intended?
>
> diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c
> index 40de151..da3c9a0 100644
> --- a/drivers/telephony/ixj.c
> +++ b/drivers/telephony/ixj.c
> @@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j)
> } else {
> switch (j->cardtype) {
> case QTI_PHONEJACK:
> - if (!j->dsp.low != 0x20) {
> + if (j->dsp.low != 0x20) {
> j->dsp.high = 0x80;
> j->dsp.low = 0x20;
> ixj_WriteDSPCommand(0x3800, j);

gee, I can't tell. Presumably it'd be safer to just delete the test -
it's a no-op at present and that code is well-tested, lol.



\
 
 \ /
  Last update: 2009-10-14 02:01    [W:1.438 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site