lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH RFC] sched: add notifier for process migration
    On 10/10/09 03:12, Peter Zijlstra wrote:
    > A well, look at set_task_cpu(): new_rq->nr_migrations_in++;
    >

    How does this look?

    From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    Date: Wed, 7 Oct 2009 13:43:31 -0700
    Subject: [PATCH] sched: add notifier for cross-cpu migrations

    It can be useful to know when a task has migrated to another cpu (to invalidate some
    per-cpu per-task cache, for example).

    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

    diff --git a/include/linux/sched.h b/include/linux/sched.h
    index 0f1ea4a..5186dd9 100644
    --- a/include/linux/sched.h
    +++ b/include/linux/sched.h
    @@ -141,6 +141,14 @@ extern unsigned long nr_iowait(void);
    extern void calc_global_load(void);
    extern u64 cpu_nr_migrations(int cpu);

    +/* Notifier for when a task gets migrated to a new CPU */
    +struct task_migration_notifier {
    + struct task_struct *task;
    + int from_cpu;
    + int to_cpu;
    +};
    +extern void register_task_migration_notifier(struct notifier_block *n);
    +
    extern unsigned long get_parent_ip(unsigned long addr);

    struct seq_file;
    diff --git a/kernel/sched.c b/kernel/sched.c
    index 1b59e26..3982e8e 100644
    --- a/kernel/sched.c
    +++ b/kernel/sched.c
    @@ -1951,6 +1951,12 @@ task_hot(struct task_struct *p, u64 now, struct sched_domain *sd)
    return delta < (s64)sysctl_sched_migration_cost;
    }

    +static ATOMIC_NOTIFIER_HEAD(task_migration_notifier);
    +
    +void register_task_migration_notifier(struct notifier_block *n)
    +{
    + atomic_notifier_chain_register(&task_migration_notifier, n);
    +}

    void set_task_cpu(struct task_struct *p, unsigned int new_cpu)
    {
    @@ -1973,6 +1979,8 @@ void set_task_cpu(struct task_struct *p, unsigned int new_cpu)
    p->se.block_start -= clock_offset;
    #endif
    if (old_cpu != new_cpu) {
    + struct task_migration_notifier tmn;
    +
    p->se.nr_migrations++;
    new_rq->nr_migrations_in++;
    #ifdef CONFIG_SCHEDSTATS
    @@ -1981,6 +1989,12 @@ void set_task_cpu(struct task_struct *p, unsigned int new_cpu)
    #endif
    perf_swcounter_event(PERF_COUNT_SW_CPU_MIGRATIONS,
    1, 1, NULL, 0);
    +
    + tmn.task = p;
    + tmn.from_cpu = old_cpu;
    + tmn.to_cpu = new_cpu;
    +
    + atomic_notifier_call_chain(&task_migration_notifier, 0, &tmn);
    }
    p->se.vruntime -= old_cfsrq->min_vruntime -
    new_cfsrq->min_vruntime;



    \
     
     \ /
      Last update: 2009-10-13 23:41    [W:0.022 / U:30.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site