lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/5] [PATCH 2/5] tracing: export symbols for kernel lock tracepoints
    From
    Date
    On Tue, 2009-10-13 at 22:43 +0200, Frederic Weisbecker wrote:
    > On Tue, Oct 13, 2009 at 04:33:51PM -0400, Steven Rostedt wrote:
    > > From: Steven Rostedt <srostedt@redhat.com>
    > >
    > > The big kernel lock tracepoints are used inside modules and they need
    > > to be exported accordingly.
    > >
    > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    > > ---
    > > lib/kernel_lock.c | 2 ++
    > > 1 files changed, 2 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/lib/kernel_lock.c b/lib/kernel_lock.c
    > > index 4ebfa5a..76f05bc 100644
    > > --- a/lib/kernel_lock.c
    > > +++ b/lib/kernel_lock.c
    > > @@ -139,3 +139,5 @@ void __lockfunc _unlock_kernel(const char *func, const char *file, int line)
    > > EXPORT_SYMBOL(_lock_kernel);
    > > EXPORT_SYMBOL(_unlock_kernel);
    > >
    > > +EXPORT_TRACEPOINT_SYMBOL(lock_kernel);
    > > +EXPORT_TRACEPOINT_SYMBOL(unlock_kernel);
    > > --
    >
    >
    > I remember when you showed me this patch, and it fixed a real
    > issue because we had the tracepoint call in smp_lock.h:
    >
    > #define lock_kernel() \
    > trace_lock_kernel(__FUNC__, __FILE__, __LINE__); \
    > _lock_kernel(); \
    >
    > So indeed the modules needed this missing export. But I had
    > to move the tracepoint calls to lib/kernel_lock.c instead,
    > because we had very bad headers dependencies.
    >
    > So it's not needed anymore.

    Ah, I missed that change. I've had this queued up for a while.

    Ingo, want me to rebase and remove this patch?

    -- Steve




    \
     
     \ /
      Last update: 2009-10-13 23:21    [W:0.021 / U:60.724 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site