Messages in this thread Patch in this message | | | Date | Tue, 13 Oct 2009 06:14:57 GMT | From | tip-bot for Li Zefan <> | Subject | [tip:tracing/urgent] tracing/filters: Fix memory leak when setting a filter |
| |
Commit-ID: 8ad807318fcd62aba0e18c7c7fbfcc1af3fcdbab Gitweb: http://git.kernel.org/tip/8ad807318fcd62aba0e18c7c7fbfcc1af3fcdbab Author: Li Zefan <lizf@cn.fujitsu.com> AuthorDate: Tue, 13 Oct 2009 09:28:57 +0800 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Tue, 13 Oct 2009 08:05:17 +0200
tracing/filters: Fix memory leak when setting a filter
Every time we set a filter, we leak memory allocated by postfix_append_operand() and postfix_append_op().
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Tom Zanussi <tzanussi@gmail.com> Cc: <stable@kernel.org> # for v2.6.31.x LKML-Reference: <4AD3D7D9.4070400@cn.fujitsu.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- kernel/trace/trace_events_filter.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index 2324578..98a6cc5 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -933,8 +933,9 @@ static void postfix_clear(struct filter_parse_state *ps) while (!list_empty(&ps->postfix)) { elt = list_first_entry(&ps->postfix, struct postfix_elt, list); - kfree(elt->operand); list_del(&elt->list); + kfree(elt->operand); + kfree(elt); } }
| |