Messages in this thread | | | Date | Tue, 13 Oct 2009 19:03:31 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH] hwpoison: fix oops on ksm pages |
| |
On Tue, 13 Oct 2009, Andi Kleen wrote: > On Tue, Oct 13, 2009 at 03:02:11PM +0100, Hugh Dickins wrote: > > Memory failure on a KSM page currently oopses on its NULL anon_vma in > > page_lock_anon_vma(): that may not be much worse than the consequence > > of ignoring it, but it is better to be consistent with how ZERO_PAGE > > and hugetlb pages and other awkward cases are treated. Just skip it. > > Thanks, Hugh. I'm curious: did this come out of code review or > did you actually run into that?
Just out of code review: well, that's too fancy a name for it, I merely remembered that I hadn't looked at ksm/hwpoison interoperabilty, so did so just now. After looking at the code, I did then try MADV_HWPOISON on a MADV_MERGEABLE area, to check that the problem and the fix were real.
Hugh
| |