Messages in this thread | | | Subject | Re: [PATCH] sysfs: mark a locally-only used function static | From | "David P. Quigley" <> | Date | Tue, 13 Oct 2009 10:42:44 -0400 |
| |
On Sun, 2009-10-11 at 03:02 +0200, Stefan Richter wrote: > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> > --- > diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c > index e28cecf..e144351 100644 > --- a/fs/sysfs/inode.c > +++ b/fs/sysfs/inode.c > @@ -46,7 +46,7 @@ int __init sysfs_inode_init(void) > return bdi_init(&sysfs_backing_dev_info); > } > > -struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd) > +static struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd) > { > struct sysfs_inode_attrs *attrs; > struct iattr *iattrs; > @@ -64,6 +64,7 @@ struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd) > > return attrs; > } > + > int sysfs_setattr(struct dentry * dentry, struct iattr * iattr) > { > struct inode * inode = dentry->d_inode; >
I don't see why this shouldn't or can't be made static. I'll ACK it and then you guys can deal with it however you like.
-Dave
| |