lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sysfs: mark a locally-only used function static
From
Date
On Sun, 2009-10-11 at 03:02 +0200, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
> diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
> index e28cecf..e144351 100644
> --- a/fs/sysfs/inode.c
> +++ b/fs/sysfs/inode.c
> @@ -46,7 +46,7 @@ int __init sysfs_inode_init(void)
> return bdi_init(&sysfs_backing_dev_info);
> }
>
> -struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
> +static struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
> {
> struct sysfs_inode_attrs *attrs;
> struct iattr *iattrs;
> @@ -64,6 +64,7 @@ struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
>
> return attrs;
> }
> +
> int sysfs_setattr(struct dentry * dentry, struct iattr * iattr)
> {
> struct inode * inode = dentry->d_inode;
>

I don't see why this shouldn't or can't be made static. I'll ACK it and
then you guys can deal with it however you like.

-Dave





\
 
 \ /
  Last update: 2009-10-13 17:49    [W:0.107 / U:9.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site