lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/3] tracing: Rename set_ftrace to set_bootup_ftrace
    From
    Date
    On Tue, 2009-10-13 at 09:38 +0200, Frederic Weisbecker wrote:
    > Do this rename because set_ftrace is too much generic and not enough
    > self-explainable as a name.
    >
    > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    > Cc: Steven Rostedt <rostedt@goodmis.org>
    > Cc: Li Zefan <lizf@cn.fujitsu.com>
    > ---
    > kernel/trace/trace.c | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
    > index 4506826..866daf8 100644
    > --- a/kernel/trace/trace.c
    > +++ b/kernel/trace/trace.c
    > @@ -129,7 +129,7 @@ static int tracing_set_tracer(const char *buf);
    > static char bootup_tracer_buf[MAX_TRACER_SIZE] __initdata;
    > static char *default_bootup_tracer;
    >
    > -static int __init set_ftrace(char *str)
    > +static int __init set_bootup_ftrace(char *str)
    > {
    > strncpy(bootup_tracer_buf, str, MAX_TRACER_SIZE);
    > default_bootup_tracer = bootup_tracer_buf;
    > @@ -137,7 +137,7 @@ static int __init set_ftrace(char *str)
    > ring_buffer_expanded = 1;
    > return 1;
    > }
    > -__setup("ftrace=", set_ftrace);
    > +__setup("ftrace=", set_bootup_ftrace);

    Actually, it probably should be called, set_cmdline_ftrace. Since it
    came from the command line, and that is what is matching.

    -- Steve

    >
    > static int __init set_ftrace_dump_on_oops(char *str)
    > {



    \
     
     \ /
      Last update: 2009-10-13 15:31    [W:0.042 / U:29.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site