lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[patch] perf_counter tools: remove expensive old debug code from perf top
    From
    Date

    perf_counter tools: remove expensive old debug code from perf top

    Calling gettimeofday() at high frequency is painful for handicapped boxen.
    The spot calling gettimeofday() is old unneeded debug code, so remove it.

    Signed-off-by: Mike Galbraith <efault@gmx.de>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Reported-by: Ingo Molnar <mingo@elte.hu>
    LKML-Reference: <new-submission>

    ---
    tools/perf/builtin-top.c | 15 +--------------
    1 file changed, 1 insertion(+), 14 deletions(-)

    Index: linux-2.6/tools/perf/builtin-top.c
    ===================================================================
    --- linux-2.6.orig/tools/perf/builtin-top.c
    +++ linux-2.6/tools/perf/builtin-top.c
    @@ -870,8 +870,6 @@ static unsigned int mmap_read_head(struc
    return head;
    }

    -struct timeval last_read, this_read;
    -
    static void mmap_read_counter(struct mmap_data *md)
    {
    unsigned int head = mmap_read_head(md);
    @@ -879,8 +877,6 @@ static void mmap_read_counter(struct mma
    unsigned char *data = md->base + page_size;
    int diff;

    - gettimeofday(&this_read, NULL);
    -
    /*
    * If we're further behind than half the buffer, there's a chance
    * the writer will bite our tail and mess up the samples under us.
    @@ -891,14 +887,7 @@ static void mmap_read_counter(struct mma
    */
    diff = head - old;
    if (diff > md->mask / 2 || diff < 0) {
    - struct timeval iv;
    - unsigned long msecs;
    -
    - timersub(&this_read, &last_read, &iv);
    - msecs = iv.tv_sec*1000 + iv.tv_usec/1000;
    -
    - fprintf(stderr, "WARNING: failed to keep up with mmap data."
    - " Last read %lu msecs ago.\n", msecs);
    + fprintf(stderr, "WARNING: failed to keep up with mmap data.\n");

    /*
    * head points to a known good entry, start there.
    @@ -906,8 +895,6 @@ static void mmap_read_counter(struct mma
    old = head;
    }

    - last_read = this_read;
    -
    for (; old != head;) {
    event_t *event = (event_t *)&data[old & md->mask];




    \
     
     \ /
      Last update: 2009-10-13 15:03    [W:0.023 / U:1.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site