lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][v8][PATCH 4/10]: Add target_pid parameter to alloc_pidmap()
    Sukadev Bhattiprolu wrote:
    >
    > Subject: [RFC][v8][PATCH 4/10]: Add target_pid parameter to alloc_pidmap()
    >

    [ snip ]

    > @@ -146,16 +146,22 @@ static int alloc_pidmap_page(struct pidm
    > return 0;
    > }
    >
    > -static int alloc_pidmap(struct pid_namespace *pid_ns)
    > +static int alloc_pidmap(struct pid_namespace *pid_ns, int target_pid)

    Please no! Better create another function, that will just
    atomic_test_and_set() the proper bit in the map. This one
    is heavy enough already.



    \
     
     \ /
      Last update: 2009-10-13 14:01    [W:0.020 / U:1.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site