lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: Remove the BKL from sys_execve


On Tue, 13 Oct 2009, Greg Ungerer wrote:

> Hi John,
>
> On 10/13/2009 08:34 AM, John Kacur wrote:
> > > From e36c53d296132bc0ddbf6d9fb43ea5ea56dbd4a2 Mon Sep 17 00:00:00 2001
> > From: John Kacur<jkacur@redhat.com>
> > Date: Mon, 12 Oct 2009 23:37:28 +0200
> > Subject: [PATCH] arch/m68knommu/kernel/process.c: Remove the BKL from
> > sys_execve
> >
> > This looks like a copy-and-paste of functionality that no-longer needs the
> > bkl.
> > Just remove it.
> >
> > Signed-off-by: John Kacur<jkacur@redhat.com>
>
> Tested and runs fine on m68knommu.
>
> Acked-by: Greg Ungerer <gerg@uclinux.org>
>
> Do you want me to push this into the m68knommu git tree,
> for eventual merging into Linus' tree? Or are you going
> to push the whole set of patches together?
>
> Regards
> Greg

@Thomas - do you want to pick this up for your proposed kill bkl tree and
push it to Linus during this next merge window - or in this case is it
more appropriate for Greg as the m68knommu maintainer to do so?

Thanks

John


> > ---
> > arch/m68knommu/kernel/process.c | 5 +----
> > 1 files changed, 1 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/m68knommu/kernel/process.c
> > b/arch/m68knommu/kernel/process.c
> > index 8f8f4ab..5c9ecd4 100644
> > --- a/arch/m68knommu/kernel/process.c
> > +++ b/arch/m68knommu/kernel/process.c
> > @@ -352,15 +352,12 @@ asmlinkage int sys_execve(char *name, char **argv,
> > char **envp)
> > char * filename;
> > struct pt_regs *regs = (struct pt_regs *)&name;
> >
> > - lock_kernel();
> > filename = getname(name);
> > error = PTR_ERR(filename);
> > if (IS_ERR(filename))
> > - goto out;
> > + return error;
> > error = do_execve(filename, argv, envp, regs);
> > putname(filename);
> > -out:
> > - unlock_kernel();
> > return error;
> > }
> >
>
> --
> ------------------------------------------------------------------------
> Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
> SnapGear Group, McAfee PHONE: +61 7 3435 2888
> 825 Stanley St, FAX: +61 7 3891 3630
> Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
>


\
 
 \ /
  Last update: 2009-10-13 13:37    [W:1.072 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site