lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [RFC][PATCH 0/2] LIS3LV02D I2C driver


    -----Original Message-----
    From: Onkalo Samu [mailto:samu.p.onkalo@nokia.com]
    Sent: Tuesday, October 13, 2009 3:44 PM
    To: ext Éric Piel; Trisal, Kalhan
    Cc: Jonathan Cameron; linux-kernel@vger.kernel.org; LM Sensors; Jean Delvare; Andrew Morton
    Subject: Re: [RFC][PATCH 0/2] LIS3LV02D I2C driver

    On Wed, 2009-10-07 at 19:26 +0200, ext Éric Piel wrote:
    > Op 07-10-09 19:01, Éric Piel schreef:
    > > Op 07-10-09 18:31, Jonathan Cameron schreef:
    > >> Just a quick heads up wrt overlapping work.
    > >>
    > >> For the i2c support Kalhan Trisal has been posting patches for i2c
    > >> support for this
    > >> driver to the lm-sensors list for some time and the latest version of that
    > >> set is also pretty clean.
    > > You mean this post, right?
    > > http://lists.lm-sensors.org/pipermail/lm-sensors/2009-August/026505.html
    > > "Accelerometer driver for STMicroeletronics-LIS331DL-three-axis-digital"
    > > Thanks for the heads up, I had never heard of this driver before.
    >
    > :
    > > Kalhan, would
    > > you mind having a look at the patch from Samu, and see what is required
    > > to get your LIS331DL working with the lis3lv02d driver? It should be
    > > very little and avoid duplication of efforts :-)
    > Ah, bah,
    > I see you have actually already more or less done this!
    > http://lists.lm-sensors.org/pipermail/lm-sensors/2009-October/026840.html
    > "I2C glue layer for lis3lv02d STMicroelectronics digital accelerometer"
    >
    > The main thing you forgot to do with this patch was to CC the maintainer
    > of the driver (AKA me) ;-)
    >
    > Anyway, this version is _very_ close to the one from Samu. It has just
    > all the basics, really clean! Samu has already added some nifty things
    > (like changing the axis conversion, support for suspend...). So it
    > should _really_ easy to converge :-) As Samu's patch is already in
    > Andrew's queue, I think it's simpler to leave it as it, and just to keep
    > my request to you, Kalhan, to check that it works for your hardware as
    > well.

    Hi Kalhan,

    Have you been able to test my patch if it works also for your HW?

    http://marc.info/?l=linux-kernel&m=125472767421625&w=2

    http://marc.info/?l=linux-kernel&m=125472767421629&w=2

    http://marc.info/?l=linux-kernel&m=125472767421639&w=2

    Br,
    Samu


    Hi Samu,
    I haven't tested your patch yet but it will work.
    I have seen the patch, the glue layer is exactly same
    what I have also tested part of my driver.

    Br
    Kalhan

    \
     
     \ /
      Last update: 2009-10-13 12:29    [W:5.842 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site