Messages in this thread | | | Date | Tue, 13 Oct 2009 12:07:08 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/4] tracing/profile: Add filter support |
| |
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> +#ifdef CONFIG_EVENT_PROFILE > +struct perf_event; > +extern int ftrace_profile_enable(int event_id); > +extern void ftrace_profile_disable(int event_id); > +extern int ftrace_profile_set_filter(struct perf_event *event, int event_id, > + char *filter_str); > +extern void ftrace_profile_free_filter(struct perf_event *event); > +#endif
This reminds me - i think we should eliminate CONFIG_EVENT_PROFILE - it's an unnecessary Kconfig complication. If both PERF_EVENTS and EVENT_TRACING is enabled we should expose generic tracepoints.
Nor is it limited to event 'profiling', so it has become a misnomer as well.
Ingo
| |