lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] tracing/profile: Add filter support

* Li Zefan <lizf@cn.fujitsu.com> wrote:

> +#ifdef CONFIG_EVENT_PROFILE
> +struct perf_event;
> +extern int ftrace_profile_enable(int event_id);
> +extern void ftrace_profile_disable(int event_id);
> +extern int ftrace_profile_set_filter(struct perf_event *event, int event_id,
> + char *filter_str);
> +extern void ftrace_profile_free_filter(struct perf_event *event);
> +#endif

This reminds me - i think we should eliminate CONFIG_EVENT_PROFILE -
it's an unnecessary Kconfig complication. If both PERF_EVENTS and
EVENT_TRACING is enabled we should expose generic tracepoints.

Nor is it limited to event 'profiling', so it has become a misnomer as
well.

Ingo


\
 
 \ /
  Last update: 2009-10-13 12:21    [W:0.060 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site