Messages in this thread | | | Date | Tue, 13 Oct 2009 10:41:14 +0200 (CEST) | From | John Kacur <> | Subject | Re: [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: Remove the BKL from sys_execve |
| |
On Tue, 13 Oct 2009, Mike Frysinger wrote:
> On Tue, Oct 13, 2009 at 04:27, John Kacur wrote: > > On Tue, 13 Oct 2009, Mike Frysinger wrote: > >> On Mon, Oct 12, 2009 at 18:33, John Kacur wrote: > >> > This looks like a cut-and-paste job. > >> > For example, compare this function to sys_execve in > >> > arch/x86/kernel/process_64.c > >> > > >> > and it is almost line by line the same, except the one in x86 nolonger has the > >> > big kernel lock. All of the functions called between the lock are generic > >> > and not specific to blackfin - thus, I believe it is safe to remove the > >> > bkl here. > >> > >> and it still boots/runs fine, so np here > >> Acked-by: Mike Frysinger <vapier@gentoo.org> > > > > Cool - are you testing on one of those nifty smp (or smp-like) blackfins? > > no, this was a uniproc. i could try a SMP Blackfin if you think it'll > make a difference. > -mike >
Well - hopefully it won't make a difference, but if there are problems, then that is where they will show up.
Thanks
| |