Messages in this thread | | | Date | Mon, 12 Oct 2009 10:28:56 +0200 | From | Tilman Schmidt <> | Subject | Re: NOHZ: local_softirq_pending 08 |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
[CCing PPP people]
Am 11.10.2009 13:40 schrieb Johannes Berg: > On Sun, 2009-10-11 at 13:18 +0200, Tilman Schmidt wrote: > >> Can you explain a bit more what that message is about? >> I am encountering it in a completely different context >> (PPP over ISDN) [...] > > Basically, calling netif_rx() with softirqs enabled.
AFAICS that would have to be the netif_rx() call in ppp_receive_nonmp_frame() [drivers/net/ppp_generic.c#L1791], called (via others) from the tasklet work function ppp_sync_process() [drivers/net/ppp_synctty.c#L545]. Should that be changed to the "if (in_interrupt()) netif_rx(skb) else netif_rx_ni(skb)" stanza from the linux.kernel.wireless.general thread then?
Thanks, Tilman
- -- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFK0ujIQ3+did9BuFsRAtGBAJ9rj2pyQZ75ZKTipLhpICqA3ZvTdQCdHQs/ RmdeOT3TuPZykXJxcHLJCzU= =87DI -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |