lkml.org 
[lkml]   [2009]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 4/5] PCI: use better error return values in aer_inject
    From
    Date
    PCI: use better error return values in aer_inject

    Replaced some error return values in aer_inject. Use -ENODEV when we
    can't find a device and -ENOTTY when the device does not support PCIe AER.

    Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
    ---

    diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
    index ac0b5e7..da2ad6e 100644
    --- a/drivers/pci/pcie/aer/aer_inject.c
    +++ b/drivers/pci/pcie/aer/aer_inject.c
    @@ -326,23 +326,23 @@ static int aer_inject(struct aer_error_inj *einj)

    dev = pci_get_domain_bus_and_slot((int)einj->domain, einj->bus, devfn);
    if (!dev)
    - return -EINVAL;
    + return -ENODEV;
    rpdev = pcie_find_root_port(dev);
    if (!rpdev) {
    - ret = -EINVAL;
    + ret = -ENOTTY;
    goto out_put;
    }

    pos_cap_err = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
    if (!pos_cap_err) {
    - ret = -EIO;
    + ret = -ENOTTY;
    goto out_put;
    }
    pci_read_config_dword(dev, pos_cap_err + PCI_ERR_UNCOR_SEVER, &sever);

    rp_pos_cap_err = pci_find_ext_capability(rpdev, PCI_EXT_CAP_ID_ERR);
    if (!rp_pos_cap_err) {
    - ret = -EIO;
    + ret = -ENOTTY;
    goto out_put;
    }



    \
     
     \ /
      Last update: 2009-10-12 09:21    [W:0.020 / U:30.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site