lkml.org 
[lkml]   [2009]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] panic.c: export panic_on_oops


    On Mon, 12 Oct 2009, Linus Torvalds wrote:
    >
    > Once you do the final flush in a controlled place _after_ you've printed
    > out all the oops information, you simply don't care about locks any more.
    > Because if you were holding critical locks, you're done anyway.
    >
    > Sure, maybe you want to do a "trylock()" and skip the oops flush entirely
    > in the mtd layer if you can't do it, but it's the "let's use a workqueue"
    > or something that doesn't seem to make a lot of sense to me.

    Side note: I don't actually care deeply. Once it's all inside some driver,
    and once it's not messing up the console layer, I don't think the small
    details matter all that much. I just think it's likely to be a sign of
    something wrong if you need to use workqueues to flush - it probably means
    that the most interesting oopses will never make it to the mtd device in
    the first place.

    Linus


    \
     
     \ /
      Last update: 2009-10-18 23:28    [W:4.913 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site