Messages in this thread | | | Date | Tue, 13 Oct 2009 02:04:15 +0900 (JST) | Subject | Re: [PATCH 1/2] rtc-ds1511: Fix races around device registration | From | Atsushi Nemoto <> |
| |
On Mon, 12 Oct 2009 18:47:39 +0200, Alessandro Zummo <alessandro.zummo@towertech.it> wrote: > > * Call dev_set_drvdata before rtc device creation > > * Use its own spinlock instead of rtc->irq_lock > > why?
Because pdata->rtc must be initialized to use the irq_lock (pdata->rtc->irq_lock). There is a small window which rtc methods can be called before pdata->rtc is initialized.
And there is no need use the irq_lock to protect hardware registers. The driver's own spinlock shoule be enough.
--- Atsushi Nemoto
| |