Messages in this thread | | | Date | Mon, 12 Oct 2009 19:14:57 +0530 | Subject | Re: [PATCH] Haptic class support (v2) | From | Trilok Soni <> |
| |
Hi Kyungmin,
On Mon, Oct 12, 2009 at 6:02 AM, Kyungmin Park <kmpark@infradead.org> wrote: > On Sun, Oct 11, 2009 at 6:05 PM, Pavel Machek <pavel@ucw.cz> wrote: >> On Tue 2009-10-06 16:45:33, Kyungmin Park wrote: >>> This patch includes two haptic devices, isa1000 and isa1200 >>> ISA1000 is gpio based haptic, but isa1200 is based on I2C >>> Both are working on Samsung SoCs and tested. >>> >>> To enable the haptic, echo 1 > /sys/class/haptic/${name}/enable >>> You can adjust the level by echo ${level} > /sys/class/haptic/${name}/enable >>> or >>> With oneshot feature, echo ${msec time} > /sys/class/haptic/${name}/oneshot >> >> New device classes should certainly be documented in Documentation/. >> >> For example... is level 0-100? > > Basically. range from 0 to 255. also each device can set max level in > case of isa1000 it's 6. > >> Is it valid to change level while 'oneshot' is running? > > we usually use it under 1 sec. but I think it's possible to change it > but not tried. > >> Does oneshot use last level set? > > Right. it used last set value. > > If you don't mind to update these at Documentation please wait until > commit first patches merged.
Let's see what Greg prefers. Could you please refresh your patchset with probably addressing comments given in the isa1200 and samsung_pwm driver by me?
-- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |