lkml.org 
[lkml]   [2009]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [this_cpu_xx V6 3/7] Use this_cpu operations in slub
Tejun Heo wrote:
> Hello,
>
> cl@linux-foundation.org wrote:
>> @@ -1507,7 +1498,7 @@ static inline void flush_slab(struct kme
>> */
>> static inline void __flush_cpu_slab(struct kmem_cache *s, int cpu)
>> {
>> - struct kmem_cache_cpu *c = get_cpu_slab(s, cpu);
>> + struct kmem_cache_cpu *c = per_cpu_ptr(s->cpu_slab, cpu);
>>
>> if (likely(c && c->page))
>> flush_slab(s, c);
>> @@ -1673,7 +1661,7 @@ new_slab:
>> local_irq_disable();
>>
>> if (new) {
>> - c = get_cpu_slab(s, smp_processor_id());
>> + c = __this_cpu_ptr(s->cpu_slab);
>
> Shouldn't this be this_cpu_ptr() without the double underscore?

Oh... another similar conversions in slab_alloc() and slab_free() too.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-10-12 12:45    [W:0.093 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site