Messages in this thread | | | Date | Sun, 11 Oct 2009 09:03:13 -0700 | From | Arjan van de Ven <> | Subject | Re: [PATCH RFC] [PATCH] drivers/scsi/ch.c: Remove BKL in ch_open |
| |
On Sun, 11 Oct 2009 16:54:08 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > > I'm not so sure. In fact there are some quite umm interesting > > > questions about this code, and some of them are shared with other > > > modules too. > > > > > > Consider the following sequence > > > > > > CPU1 CPU2 > > > register_chrdev > > > ok > > > open device > > > takes lock > > > > > > but open does not take the BKL, so the BKL is not protecting you at > > all against this.. > > But module load/unload does
it does?
looking at the code.... so far failing to find where.
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |