lkml.org 
[lkml]   [2009]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 11/28] nvram: Drop the bkl from nvram_llseek()
    On Sun, Oct 11, 2009 at 11:08:10PM +0200, Frederic Weisbecker wrote:
    > On Sun, Oct 11, 2009 at 09:31:40PM +0200, Arnd Bergmann wrote:
    > > On Saturday 10 October 2009, Thomas Gleixner wrote:
    > > > There is nothing to protect inside nvram_llseek(), the file
    > > > offset doesn't need to be protected and nvram_len is only
    > > > initialized from an __init path.
    > > >
    > > > It's safe to remove the big kernel lock there.
    > > >
    > >
    > > The generic_nvram driver still uses ->ioctl instead of ->unlocked_ioctl.
    > > I guess it would be helpful to change that in the same series, so we
    > > don't get the BKL back as soon as someone does a pushdown into the
    > > remaining ioctl functions.
    > >
    > > Arnd <><
    >
    >
    > Right!
    > I'll add that in a second patch.
    >
    > I've completely forgotten this ioctl/unlocked_ioctl thing.


    BTW, I was focusing on the lock_kernel() callsites in the kernel which
    are around 626 (I've excluded reiserfs)

    Now I'm adding the ioctl() sites too:

    git-grep "\.ioctl *=" | grep -P "^\S+\.c" | wc -l
    452

    Hehe :)



    \
     
     \ /
      Last update: 2009-10-11 23:47    [W:0.022 / U:32.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site