lkml.org 
[lkml]   [2009]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] PM / Hibernate: fix error handling in save_image
On Sat 2009-10-10 13:51:45, Jiri Slaby wrote:
> There are too many retval variables in save_image. Thus error return
> value from snapshot_read_next may be ignored and only part of the
> snapshot (successfully) written.
>
> Remove 'error' variable, invert the condition in the do-while loop
> and convert the loop to use only 'ret' variable.
>
> Switch the rest of the function to consider only 'ret'.
>
> Also make sure we end printed line by \n if an error occurs.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

ACK.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-10-10 14:21    [W:0.081 / U:3.188 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site