lkml.org 
[lkml]   [2009]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 22/28] macintosh: Remove BKL from ans-lcd
    > There were 4 checkpatch errors on this patch, all of the type
    > ERROR: spaces required around that '=' (ctx:WxO)
    > #1466: FILE: drivers/macintosh/ans-lcd.c:112:
    > + ret =-EACCES;

    Here's a suggestion. If a few spaces bug you that much then instead of
    complaining about it and posting checkpatch results deal with the file
    itself.

    Wait until the patch goes in and send a follow up patch that fixes up the
    file to fit codingstyle. There's no point whining about the bits a patch
    touches when the file wasn't in that format before, but if you've got
    nothing better to do then doing a pass over the whole file *is* useful.

    (Plus it gets a patch to your name ;))

    Checkpatch whines on files that simple don't follow style are usually
    best ignored because they make the file formatting less internally
    consistent.

    Alan


    \
     
     \ /
      Last update: 2009-10-11 01:17    [W:2.211 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site