Messages in this thread | | | Date | Sat, 10 Oct 2009 21:19:20 +0200 | From | Nicolas de Pesloüan <> | Subject | Re: [Bonding-devel] [PATCH] net, bonding: Add return statement in bond_create_proc_entry. |
| |
Rakib Mullick wrote: > The function bond_create_proc_entry supposed to return int instead of void. > And fixes the following compilation warning. > > drivers/net/bonding/bond_main.c: In function `bond_create_proc_entry': > drivers/net/bonding/bond_main.c:3393: warning: control reaches end of > non-void function > > --- > Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com> > > --- linus/drivers/net/bonding/bond_main.c 2009-10-09 17:38:35.000000000 +0600 > +++ rakib/drivers/net/bonding/bond_main.c 2009-10-09 17:47:46.000000000 +0600 > @@ -3391,6 +3391,7 @@ static void bond_destroy_proc_dir(void) > > static int bond_create_proc_entry(struct bonding *bond) > { > + return 0; > }
This empty function is defined inside the else branch of an ifdef. The corresponding non-empty function always return 0 and no caller of this function use the returned value.
So I suggest to change the return type of this function from int to void, instead of adding a return 0 into the empty one.
Nicolas.
| |