Messages in this thread | | | From | Frans Pop <> | Subject | Re: kernel BUG at drivers/ide/ide-disk.c:187 (2.6.31) | Date | Thu, 1 Oct 2009 10:26:14 +0200 |
| |
Hi Manty,
Andrew Morton wrote: > On Wed, 30 Sep 2009 13:05:29 +0200 Santiago Garcia Mantinan wrote: >> kernel BUG at drivers/ide/ide-disk.c:187!
Looks like this is a deliberate test for unknown requests that was added in 2.6.31 with the following commit:
commit 2c7eaa43c3bb7b3b9fe2051d17f308c1f0728c78 Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Date: Mon Jun 15 22:16:10 2009 +0200
ide: BUG() on unknown requests
Unsupported requests should be never handed down to device drivers and the best thing we can do upon discovering such request inside driver's ->do_request method is to just BUG().
In previous kernels the code would not dump, but still fail and print the request flags, identified by "ide_do_rw_disk - bad command", to the kernel log. Manty: Have you ever seen such messages with previous kernels?
Question for IDE maintainers: should maybe the old printing of request info be reinstated, or can the request flags also be obtained from the BUG info?
Cheers, FJP
| |