[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[072/136] net: Make the copy length in af_packet sockopt handler unsigned

2.6.31-stable review patch. If anyone has any objections, please let us know.

From: Arjan van de Ven <>

fixed upstream in commit b7058842c940ad2c08dd829b21e5c92ebe3b8758 in a different way

The length of the to-copy data structure is currently stored in
a signed integer. However many comparisons are done with sizeof(..)
which is unsigned. It's more suitable for this variable to be unsigned
to make these comparisons more naturally right.

Signed-off-by: Arjan van de Ven <>
Cc: David S. Miller <>
Cc: Ingo Molnar <>
Cc: Linus Torvalds <>
Signed-off-by: Greg Kroah-Hartman <>

net/packet/af_packet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -1836,7 +1836,7 @@ packet_setsockopt(struct socket *sock, i
static int packet_getsockopt(struct socket *sock, int level, int optname,
char __user *optval, int __user *optlen)
- int len;
+ unsigned int len;
int val;
struct sock *sk = sock->sk;
struct packet_sock *po = pkt_sk(sk);
@@ -1849,7 +1849,7 @@ static int packet_getsockopt(struct sock
if (get_user(len, optlen))
return -EFAULT;

- if (len < 0)
+ if ((int)len < 0)
return -EINVAL;

switch (optname) {

 \ /
  Last update: 2009-10-02 03:53    [W:0.297 / U:6.104 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site