Messages in this thread | | | Date | Thu, 1 Oct 2009 21:28:06 -0400 | From | Konrad Rzeszutek <> | Subject | Re: [PATCH] iSCSI/iBFT: use proper address translation |
| |
On Thu, Oct 01, 2009 at 02:46:52PM -0700, Jeremy Fitzhardinge wrote: > On 10/01/09 01:01, Jan Beulich wrote: > > In virtual environments (namely, Xen Dom0) virt <-> phys and > > virt <-> isa-bus translations cannot be freely interchanged. When > > looking at memory below 1M, the latter translations should always > > be used. > > > > Do you have a different definition for isa_virt_to_bus in your kernel? > As far as I can see it is defined to be the same as virt_to_phys. Also, > the ISA memory is identity mapped into the domain's physical mapping > space, so it should be directly accessible without any problems.
The issue as I've come to understand is that the virt_to_phys on memory below the 1MB does not work. Alex suggested another fix which ioremap's the iBFT region, but I think this patch by Martin does the same job.
Either way, it looks good to me.
Signed-off-by: Konrad Rzeszutek Wilk <ketuzsezs@darnok.org>
| |