[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch 17/30] ahci: restore pci_intx() handling
    2.6.30-stable review patch.  If anyone has any objections, please let us know.

    From: Tejun Heo <>

    commit 31b239ad1ba7225435e13f5afc47e48eb674c0cc upstream.

    Commit a5bfc4714b3f01365aef89a92673f2ceb1ccf246 dropped explicit
    pci_intx() manipulation from ahci because it seemed unnecessary and
    ahci doesn't seem to be the right place to be tweaking it if it were.
    This was largely okay but there are exceptions. There was one on an
    embedded platform which was fixed via firmware and now bko#14124
    reports it on a HP DL320.

    I still think this isn't something libata drivers should be caring
    about (the only ones which are calling pci_intx() explicitly are
    libata ones and one other driver) but for now reverting the change
    seems to be the right thing to do.

    Signed-off-by: Tejun Heo <>
    Reported-by: Thomas Jarosch <>
    Signed-off-by: Jeff Garzik <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/ata/ahci.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/ata/ahci.c
    +++ b/drivers/ata/ahci.c
    @@ -2744,8 +2744,8 @@ static int ahci_init_one(struct pci_dev
    if (board_id == board_ahci_sb700 && pdev->revision >= 0x40)
    hpriv->flags &= ~AHCI_HFLAG_IGN_SERR_INTERNAL;

    - if (!(hpriv->flags & AHCI_HFLAG_NO_MSI))
    - pci_enable_msi(pdev);
    + if ((hpriv->flags & AHCI_HFLAG_NO_MSI) || pci_enable_msi(pdev))
    + pci_intx(pdev, 1);

    /* save initial config */
    ahci_save_initial_config(pdev, hpriv);

     \ /
      Last update: 2009-10-02 01:45    [W:0.020 / U:33.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site