lkml.org 
[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 8/9] netfilter: bridge: refcount fix

    2.6.27-stable review patch. If anyone has any objections, please let us know.

    ------------------

    From: Patrick McHardy <kaber@trash.net>

    netfilter: bridge: refcount fix

    Upstream commit f3abc9b9:

    commit f216f082b2b37c4943f1e7c393e2786648d48f6f
    ([NETFILTER]: bridge netfilter: deal with martians correctly)
    added a refcount leak on in_dev.

    Instead of using in_dev_get(), we can use __in_dev_get_rcu(),
    as netfilter hooks are running under rcu_read_lock(), as pointed
    by Patrick.

    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/bridge/br_netfilter.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/bridge/br_netfilter.c
    +++ b/net/bridge/br_netfilter.c
    @@ -358,7 +358,7 @@ static int br_nf_pre_routing_finish(stru
    },
    .proto = 0,
    };
    - struct in_device *in_dev = in_dev_get(dev);
    + struct in_device *in_dev = __in_dev_get_rcu(dev);

    /* If err equals -EHOSTUNREACH the error is due to a
    * martian destination or due to the fact that



    \
     
     \ /
      Last update: 2009-10-02 01:27    [W:0.024 / U:151.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site