Messages in this thread | | | Subject | Re: [PATCH] LED driver for Intel NAS SS4200 series (v4) | From | Joe Perches <> | Date | Thu, 01 Oct 2009 15:37:42 -0700 |
| |
On Thu, 2009-10-01 at 15:28 -0700, Dave Hansen wrote: > Changes from last version > * Changed logging functions to use cleaner helpers > diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c [] > +#ifdef pr_fmt > +#undef pr_fmt > +#endif > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Hi Dave.
Thanks for doing this.
Minor nit: I think the preferred style is to put the #define pr_fmt before any #include.
cheers, Joe
| |