lkml.org 
[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3
    From
    From: Shreyas Bhatewara <sbhatewara@vmware.com>
    Date: Wed, 30 Sep 2009 14:34:57 -0700 (PDT)

    > +{
    > + struct vmxnet3_adapter *adapter = netdev_priv(netdev);
    > + u8 *base;
    > + int i;
    > +
    > + VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
    > VMXNET3_CMD_GET_STATS);
    > +
    > + /* this does assume each counter is 64-bit wide */
    > +
    > + base = (u8 *)&adapter->tqd_start->stats;
    > + for (i = 0; i < ARRAY_SIZE(vmxnet3_tq_dev_stats); i++)
    > + *buf++ = *(u64 *)(base + vmxnet3_tq_dev_stats[i].offset);
    > +
    > + base = (u8 *)&adapter->tx_queue.stats;
    > + for (i = 0; i < ARRAY_SIZE(vmxnet3_tq_driver_stats); i++)
    > + *buf++ = *(u64 *)(base + vmxnet3_tq_driver_stats[i].offset);
    > +
    > + base = (u8 *)&adapter->rqd_start->stats;

    There's a lot of code like this that isn't indented properly. Either
    that or your email client has corrupted the patch by breaking up long
    lines or similar.

    Another example:

    > +static int
    > +vmxnet3_set_rx_csum(struct net_device *netdev, u32 val)
    > +{
    > + struct vmxnet3_adapter *adapter = netdev_priv(netdev);
    > +
    > + if (adapter->rxcsum != val) {
    > + adapter->rxcsum = val;
    > + if (netif_running(netdev)) {
    > + if (val)
    > + adapter->shared->devRead.misc.uptFeatures |=
    > + UPT1_F_RXCSUM;
    > + else
    > + adapter->shared->devRead.misc.uptFeatures &=
    > + ~UPT1_F_RXCSUM;
    > +
    > + VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
    > + VMXNET3_CMD_UPDATE_FEATURE);
    > + }
    > + }
    > + return 0;
    > +}

    Yikes! :-)



    \
     
     \ /
      Last update: 2009-10-02 00:25    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean