lkml.org 
[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: IO scheduler based IO controller V10
From
Date
On Wed, 2009-09-30 at 16:24 -0400, Vivek Goyal wrote:
> On Wed, Sep 30, 2009 at 10:05:39PM +0200, Mike Galbraith wrote:
> >
> >
> > > /*
> > > + * We may have seeky queues, don't throttle up just yet.
> > > + */
> > > + if (time_before(jiffies, cfqd->last_seeker + CIC_SEEK_THR))
> > > + return 0;
> > > +
> >
> > bzzzt. Window too large, but the though is to let them overload, but
> > not instantly.
> >
>
> CIC_SEEK_THR is 8K jiffies so that would be 8seconds on 1000HZ system. Try
> using one "slice_idle" period of 8 ms. But it might turn out to be too
> short depending on the disk speed.

Yeah, it is too short, as is even _400_ ms. Trouble is, by the time
some new task is determined to be seeky, the damage is already done.

The below does better, though not as well as "just say no to overload"
of course ;-)

I have a patchlet from Corrado to test, likely better time investment
than poking this darn thing with sharp sticks.

-Mike

grep elapsed testo.log
0.894345911 seconds time elapsed <== solo seeky test measurement
3.732472877 seconds time elapsed
3.208443735 seconds time elapsed
4.249776673 seconds time elapsed
2.763449260 seconds time elapsed
4.235271019 seconds time elapsed

(3.73 + 3.20 + 4.24 + 2.76 + 4.23) / 5 / 0.89 = 4... darn.

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index e2a9b92..44a888d 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -174,6 +174,8 @@ struct cfq_data {
unsigned int cfq_slice_async_rq;
unsigned int cfq_slice_idle;

+ unsigned long od_stamp;
+
struct list_head cic_list;

/*
@@ -1296,19 +1298,26 @@ static int cfq_dispatch_requests(struct request_queue *q, int force)
/*
* Drain async requests before we start sync IO
*/
- if (cfq_cfqq_idle_window(cfqq) && cfqd->rq_in_driver[BLK_RW_ASYNC])
+ if (cfq_cfqq_idle_window(cfqq) && cfqd->rq_in_driver[BLK_RW_ASYNC]) {
+ cfqd->od_stamp = jiffies;
return 0;
+ }

/*
* If this is an async queue and we have sync IO in flight, let it wait
*/
- if (cfqd->sync_flight && !cfq_cfqq_sync(cfqq))
+ if (cfqd->sync_flight && !cfq_cfqq_sync(cfqq)) {
+ cfqd->od_stamp = jiffies;
return 0;
+ }

max_dispatch = cfqd->cfq_quantum;
if (cfq_class_idle(cfqq))
max_dispatch = 1;

+ if (cfqd->busy_queues > 1)
+ cfqd->od_stamp = jiffies;
+
/*
* Does this cfqq already have too much IO in flight?
*/
@@ -1326,6 +1335,12 @@ static int cfq_dispatch_requests(struct request_queue *q, int force)
return 0;

/*
+ * Don't start overloading until we've been alone for a bit.
+ */
+ if (time_before(jiffies, cfqd->od_stamp + cfq_slice_sync))
+ return 0;
+
+ /*
* we are the only queue, allow up to 4 times of 'quantum'
*/
if (cfqq->dispatched >= 4 * max_dispatch)
@@ -1941,7 +1956,7 @@ static void
cfq_update_idle_window(struct cfq_data *cfqd, struct cfq_queue *cfqq,
struct cfq_io_context *cic)
{
- int old_idle, enable_idle;
+ int old_idle, enable_idle, seeky = 0;

/*
* Don't idle for async or idle io prio class
@@ -1949,10 +1964,19 @@ cfq_update_idle_window(struct cfq_data *cfqd, struct cfq_queue *cfqq,
if (!cfq_cfqq_sync(cfqq) || cfq_class_idle(cfqq))
return;

+ if (cfqd->hw_tag) {
+ if (CIC_SEEKY(cic))
+ seeky = 1;
+ /*
+ * If known or incalculable seekiness, delay.
+ */
+ if (seeky || !sample_valid(cic->seek_samples))
+ cfqd->od_stamp = jiffies;
+ }
+
enable_idle = old_idle = cfq_cfqq_idle_window(cfqq);

- if (!atomic_read(&cic->ioc->nr_tasks) || !cfqd->cfq_slice_idle ||
- (cfqd->hw_tag && CIC_SEEKY(cic)))
+ if (!atomic_read(&cic->ioc->nr_tasks) || !cfqd->cfq_slice_idle || seeky)
enable_idle = 0;
else if (sample_valid(cic->ttime_samples)) {
if (cic->ttime_mean > cfqd->cfq_slice_idle)
@@ -2482,6 +2506,7 @@ static void *cfq_init_queue(struct request_queue *q)
cfqd->cfq_slice_async_rq = cfq_slice_async_rq;
cfqd->cfq_slice_idle = cfq_slice_idle;
cfqd->hw_tag = 1;
+ cfqd->od_stamp = INITIAL_JIFFIES;

return cfqd;
}





\
 
 \ /
  Last update: 2009-10-01 09:35    [from the cache]
©2003-2011 Jasper Spaans