lkml.org 
[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/19] workqueue: update cwq alignement and make one more flag bit available
David Howells wrote:
> Jeff Garzik <jeff@garzik.org> wrote:
>
>> The quoted code is a standard kernel technique for creating typed constants
>> that are visible to the C compiler (rather than CPP) and debugger.
>>
>> It is found in a great many Linux kernel drivers at this point, and is
>> definitely not abuse, IMO.
>
> Just because it's common practice, and just because you like it, doesn't make
> it not abuse. But that's a side issue, and fairly irrelevant to the actual
> implementation.

Yeap, that's something I picked up from Jeff while working on libata
and I'm quite fond of it. I haven't encountered any downside of it
yet. Any reason why you think it's an abuse? But, at any rate, yeap,
it's a pretty peripheral issue.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-10-01 18:35    [W:1.021 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site