Messages in this thread | | | Date | Thu, 1 Oct 2009 08:01:05 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/1] Kobject: bail early if no new_parent in kobject_move() |
| |
On Thu, Oct 01, 2009 at 06:01:50PM +0300, Phil Carmody wrote: > On Thu, 2009-10-01 at 16:49 +0200, ext Greg KH wrote: > > On Thu, Oct 01, 2009 at 05:50:48PM +0300, Phil Carmody wrote: > > > From: Phil Carmody <ext-phil.2.carmody@nokia.com> > > > > > > In the absense of kobj->kset, new_parent would remain NULL. > > > NULL-dereference shenanighans then ensues in the subsequent > > > sysfs_move_dir(..., new_parent) call. Bail early instead. > > > > What caller causes this to happen? > > It was spotted by static code analysis. If there's no such path, > then the ``if (kobj->kset)'' condition itself would be unnecessary.
Hm, as there are only 2-3 callers of rename, I guess this isn't that big of a deal. I'll queue it up for .33.
thanks,
greg k-h
| |