lkml.org 
[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication
    On (Thu) Oct 01 2009 [12:28:30], Christian Borntraeger wrote:
    > Am Mittwoch 30 September 2009 19:13:21 schrieben Sie:
    > > On (Tue) Sep 29 2009 [15:31:23], Christian Borntraeger wrote:
    > > > Am Dienstag 29 September 2009 15:09:50 schrieb Amit Shah:
    > > > > Great, thanks. However I was thinking of moving this init to the
    > > > > probe() routine instead of in the init_conosle routine just because
    > > > > multiple consoles can be added and we don't want to init this each
    > > > > time.. just once in probe is fine.
    > > >
    > > > If you have new patch CC me and I can give it a spin.
    > >
    > > Hey Christian,
    > >
    > > I have a new patch that changes a few things:
    > > - moves the put_char fix to probe instead of doing it in
    > > init_port_console(), which gets called on each console port found.
    > > - uses port->id instead of a static hvc_vtermno to pass on a value to
    > > hvc_alloc(). Motivation explained within comments in the code.
    > > - A few other changes that introduce and make use of port->vcon instead
    > > of accessing the static virtconsole directly -- aimed at easing future
    > > fix to have multiple virtio-console devices.
    > >
    > > It would be great if you could test this.
    >
    > With the latest git kernel + your patch I sometmes get a completely frozen
    > console. In the dump there is
    >
    > <3>virtio_console virtio0: output:id 68 is not a head!
    >
    > Seems that I can reproduce it with large amounts of output (find / for example)
    > Without your patch everything is fine.

    Do you mean the entire patch? Or just the last snippet that I sent?

    I'm testing things using a few days old linux-next; I guess you're
    seeing this with Linus' git tree?

    I'll try that.

    Amit


    \
     
     \ /
      Last update: 2009-10-01 12:47    [W:0.027 / U:0.184 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site